[Gegl-developer] Hi, need any help?

[Sven Neumann]

Hi,

On Mon, 2008-03-10 at 00:35 +0100, Jan Heller wrote:

> Glad to hear it :) So here is the patch. Essentially, it
> implements coalesced hashing as BablHashTable structure and
> uses it as the babl database data structure. The code is not
> long and is quite self-explanatory I believe, although I
> wouldn't mind adding a few comments if needed. 

Thanks for the patch. Here are some comments that I collected when
reading through the patch:

I would prefer if this functionality could be added in new files
babl-list.[ch] and babl-hash-table.[ch]. Also the hash-table functions
should be prefixed with babl_hash_table_ instead of just babl_hash_ as
we should keep the babl_hash prefix for hash functions. Then I don't
understand the purpose of babl_list_each_NEW(). This is just temporary,
isn't it?

Oh, and if Pippin wouldn't object against making babl depend on glib, we
wouldn't have to duplicate all this code...


Sven