[Gegl-developer] Cleaning up gegl_buffer_void
Martin Nordholts
enselic at gmail.com
Thu Jun 18 10:01:55 PDT 2009
Adam Turcotte wrote:
> I noticed that there is a method in gegl-buffer.c called
> gegl_buffer_void () that contains a comment /* FIXME: handle z==0
> correctly */. The code seemed rather messy, so I cleaned it up without
> modifying the behaviour
Nice thanks
> (I'm fairly certain).
>
There is no need to be unsure here, since these kind of changes should
come along with test cases (unless there already is a tests for this
code, which I suspect is the case). The test for GEGL lives in ./tests
and you run them with 'make check'.
> Below, I provide the original code and my modified version, along with
> an explanation of the changes I have made.
>
Instead, please provide the changes as a patch, and the reasoning in the
commit message. GEGL uses git for version control.
Best regards,
Martin
More information about the Gegl-developer
mailing list