[Gimp-developer] $HOME

[Klaus Ethgen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sa den 16. Feb 2008 um 17:48 schrieb Sven Neumann:
> > I see no point how to make it more simple. 3 lines vs. one line is not
> > that more complexity.
> 
> It is three times as complex.

True.

> And we will most likely want to make it even more complex and add a
> check that the directory pointed to by the HOME environment variable
> does actually exist.

Ehem, why didn't you do that before? I agree, that should be checked
anyway. But this is independent of the $HOME way. And, if the $HOME
doesn't exist the user might have other problems which is prevents gimp
running anyway. (.Xauthority for example)

> > > It would be better to define gimp_get_home_dir() in
> > > libgimpbase/gimpenv.c und use that all over the place.
> > 
> > Sure, can be done. And might be more abstract. But in that case please
> > define the stuff inline else the overhead for the function call would be
> > to high.
> 
> It is absolutely pointless to worry about function call overhead here.
> This is not something that is being called from inner loops. Whatever we
> do here, even if we would make the function run a hundred times slower,
> it would not have any noticeable impact.

Ok. But why wasting resources if there is a easy place to hold it down?

Regards
   Klaus
- -- 
Klaus Ethgen                            http://www.ethgen.de/
pub  2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <Klaus at Ethgen.de>
Fingerprint: D7 67 71 C4 99 A6 D4 FE  EA 40 30 57 3C 88 26 2B
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBR7coyZ+OKpjRpO3lAQIgWgf/SE72A/QFOt9ucrgMj5LrPRmJNt5qMfCJ
UMb+VkSO2/ntsNAa0gNc10bM6wXqn6nLpkCPXZojK/ejbNmySTO5bd9VTnGkPkTO
tMmWRe263p3K67RXdKj8VApzI9aPGobyLK4Ai8JyGmRNUt9PYtlctwX2b9HF8N9j
JkCBwArHn0V17T9Rd/djgiiaT2CZ1uSu2b03xJ2KhgGcjxc1nnbj6qcn8taNS+M7
hHnWuGsZsWzYAWdDlC8nbKMruULTm/BIf0zMKGcEmefPqhefwNsFbO+8h2Ve5PQK
PI3ivTSGIVeih7KsY9uXIvX4O6db7UxNrNxTrbFMM8lhFIKZkW1Nww==
=P6+w
-----END PGP SIGNATURE-----