[Gimp-developer] Tagging of Gimp Resources project status

[David Gowers]

Hello,

On Tue, Jul 15, 2008 at 10:01 AM, David Gowers <00ai99 at gmail.com> wrote:
> On Tue, Jul 15, 2008 at 1:06 AM, Bill Skaggs <weskaggs at gmail.com> wrote:
>> Here is to me the most important question.  Suppose the user wants
>> to switch back and forth among a few brushes that don't have any
>> natural relationship.  Suppose for example that the user wants to draw
>> with a pencil brush, and then erase parts of the drawing with a round
>> parametric brush, and repeat the cycle.  Is this sort of thing going to
>> be supported in a way that is easy for the user?
>>
>>  -- Bill
>
> Cycling between the brushes in the filtered view could do this (so,
> tag both with 'quickdraw' then use the action -- notice their ordering
> is not user-controllable in this scenario). I think 'next brush' and
> 'previous brush' actions that already exist should handle this.
>
> However, they appear not to cycle currently -- ie going back from the
> first brush leaves you at the first brush rather than the last, and
> vice versa.
>  This should really be fixed -- cycling makes more sense for
> GimpData's (brush, pattern, palette) than the current, clipping,
> behaviour.
> Looking at the code in app/actions/actions.c, it seems that all we
> need is to change action_select_object() to support wrapping, and then
> use that parameter (in context-commands.c and layers-commands.c).
>
> A diff is attached that implements the suggested changes.
.. I am puzzled by how this message got double posted.

I left a file out of the diff and some formatting was incorrect. Here
is the revised diff.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cycle-gimpdata.diff
Type: text/x-patch
Size: 2778 bytes
Desc: not available
Url : /lists/gimp-developer/attachments/20080715/42533187/attachment.bin