[Gimp-developer] [PATCH 3/4] Tile caching performance patches

Sven Neumann sven at gimp.org
Tue Jun 2 13:59:26 PDT 2009


Hi,

a few more coding style despite the ones I already pointed out:

> +  if(!tile)return FALSE;

Please write this as

  if (! tile)
    return FALSE;

> +      if(PENDING_WRITE(t))
> +        acc+=t->size;
> +      t=t->next;

Please insert an empty line like this:

  if (PENDING_WRITE (t))
    acc += t->size;

  t = t->next;


Other than these style issues, the patch looks good. In particular your
benchmarking data looks promising. Nice work!


Sven




More information about the Gimp-developer mailing list