[Gimp-developer] [PATCH 2/4] Tile caching performance patches

Christopher Montgomery xiphmont at gmail.com
Tue Jun 2 13:57:50 PDT 2009


>> +#ifdef TILE_PROFILING
>> +#include <sys/time.h>
>
> If we use GTimeVal instead of struct timeval, we can avoid this include
> (and a possible portability problem).

Agreed.

> These lines don't adhere to the coding style guidelines. Please add a
> space after the if and move the opening curly bracket to the next line.
> There are other places in your patches that need similar fixes.

I'll make that change too and resubmit.

Monty


More information about the Gimp-developer mailing list