[Gimp-developer] Save + export spec essentials implemented

[David Gowers]

On Thu, May 7, 2009 at 7:54 AM, Martin Nordholts <enselic at gmail.com> wrote:
> Hi
>
> I have been working on implementing the Save + export spec [1] for a while.
> Since it will affect the workflow for basically everyone it would be nice
> with getting some testing and comments before we finalize, merge and push to
> GNOME master. The patches are attached to the bug report
> http://bugzilla.gnome.org/show_bug.cgi?id=581655 . Quick-guide to apply and
> test:
>
>   cd ~/source/gimp
>   tar -zxvf save-plus-export-2009-05-06.tar.gz
>   git checkout -b save-plus-export-2009-05-06 master
>   git am save-plus-export-2009-05-06/*
>
> this will create and switch to a new branch based on top of your local
> master branch, and apply the patches to that branch. Then you build and
> install as usual.

This doesn't seem to work -- patch #0010 fails:

"
Applying app: Add an 'export' mode to the file save dialog
error: patch failed: app/dialogs/file-save-dialog.c:138
error: app/dialogs/file-save-dialog.c: patch does not apply
Patch failed at 0010.
"
The patch appears to be offset by about 10 lines.

I applied it manually, and then ran git-am --skip
Patch 0011 applied ok,
Patch 0012 had problems:
"Applying app: Improve save and export error messages
error: app/dialogs/file-save-dialog.c: does not match index
Patch failed at 0012."

Applied that manually,
Patches 013..017 applied OK.
018 says :
"Applying app: Remember last export URI for each image
error: app/dialogs/file-save-dialog.c: does not match index
error: patch failed: app/file/gimp-file.h:27
error: app/file/gimp-file.h: patch does not apply
Patch failed at 0018.
"
Done manually,
019 fails similarly, done manually,
same for 020, 021
022 applied ok.

It's possible that I didn't understand how to 'resolve' a problem (
now I think it is, apply the patch manually, 'git add' the relevant
files, and 'git am --resolved')

I'm now trying to build it..
Trying it out..

This works REALLY well! I <3 it! It behaves much more comfortably than
the old setup,
I anticipate no longer needing to awkwardly 'save copy' so frequently
simply to get a web-usable version of the image.

I like how, if I hit 'revert', it properly reverts to the source image
(eg 12.gif rather than the working document 12.xcf)

I was confused by how 'export to foo.png' was only usable once the
image became dirty (ie. I changed it ). If that is considered
appropriate behaviour, then your ability to 'save' should also depend
on the dirtiness of the image


David