[Gimp-docs] please, check my patch of gimp user manaul

[Axel Wernicke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
Am 01.05.2006 um 06:21 schrieb Dust:
> p.s. my patch file : http://mr-dust.pe.kr/gimp/gimp-help-2.patch
> my works : http://mr-dust.pe.kr/gimp/gimp.zip

OK,

I had a look into your patch. It looks pretty good. I merged it and  
it will be commited in a couple of minutes (Please note, that due to  
some caching it might take up to 24h until you see the changes in the  
public cvs server).

I'd just like to have some minor suggestions, which by the way should  
be interesting for every author:

- - please stick to the alphabetical order for the different languages:
  --> en;cs;de;fr;it;ko;nl;zh_CN
  note: since en is the "leading" language, it is mostly put in front  
of everything else

- - use " to embrace attributes in xml tags -> lang="ko" instead of  
lang='ko'

- - you have lots of dead references in your text. Please do not enable  
references to other chapters as long as they are not translated to  
you language yet. It's good to do something like:

<!-- PENDING: ko <link linkend="gimp-foo-bar">foo bar</link> -->

This way you can later search for "PENDING: ko" and enable the links  
very fast after the chapters are translated.
DEAD REFERENCES ARE ERRORS THAT USUALLY PROHIBIT COMMITING A PATCH  
(big exception from that rule for you for this time only!)

- - you should zip the patch and attach all changed or new images to  
the zip as well. It is impossible for the commiter to search for  
missing images in time.

- - please set the print resolution for screenshots and large examples  
to 144dpi - This is necessary to produce good looking pdf files that  
can be printed.

All in all just minor issues! Please keep up the good work!

Greetings, lexA

>
>
>
>
> ---------------------------------------------------------------------- 
> --
> 새로운 기부 문화의 씨앗, 해피빈
> http://happybean.naver.com
> _______________________________________________
> Gimp-docs mailing list
> Gimp-docs at lists.XCF.Berkeley.EDU
> https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-docs

- ---
Live is like a chocolate box, you never know what you wanna get...
GPG Signatur auf http://wernicke-online.net/Impressum/ prüfen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFEVdffR9mXLVsAbiQRAnxAAKCQ7odDUhlvwdkZ2/xXdbiEpE038gCg5kXl
4SautV2TDoSEZS1omIQW5w8=
=GUvw
-----END PGP SIGNATURE-----